Repository navigation
Stdlib: thin AOT stream_context_set_params notification Closures (#27573) - #27842
Merged
Merged
Conversation
NestedJIT of StreamContextJitHelper fails LLVM verify under thin standalone; emit create/set_params/get_params from hashtable markers and load context HTs via valuePtrFromVariable so notification Closures survive get_params. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/27573-stream-context-set-params-aot
branch
from
August 5, 2026 17:56
6b246c7 to
8ee2e37
Compare
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/compile.phpSIGSEGV'd while NestedJIT-compilingStreamContextJitHelper(is_scalarstructGep + invalid helper IR).JitStreamContextThinAotbuilds create/set_params/get_params fromVmStreamContextmarker keys (peer Regression: AOT stream_get_meta_data(php://memory) empty keys — VM/JIT match Zend (ext/standard/streams.c) #27659 meta).JitValueBox::valuePtrFromVariable(sibling loaders updated) so set_params writes the live context; notification Closures surviveget_params.php-src reference
ext/standard/streamsfuncs.c—stream_context_set_params/parse_context_paramsTest plan
true/has_notifStreamContextRuntimeShrinkTestOK (15 tests)stream_context_set_params_notification.phptNot covered: full
ci-fast; deepset_optionoptions merge (queued #27295 / #27437).Made with Cursor