Repository navigation
Stdlib: thin AOT stream_get_meta_data php://memory|temp keys (#27659) - #27833
Merged
Merged
Conversation
NestedJIT VmFs never sees phpc_stream_* slots that JitStreamIoKernel fopen fills under thin standalone; build the meta HT in LLVM from the path table. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmFsslots for streams opened viaJitStreamIoKernellibc fopen —stream_get_meta_data()returned an empty/missing-key array (?/?/NULL).StreamGlobalsJitpath + FILE* tables (JitStreamMetaThinAot), matching php-srcstreamsfuncs.c/php_stream_get_meta_datakeys forphp://memory(MEMORY) andphp://temp(TEMP).php-src reference
ext/standard/streamsfuncs.c—PHP_FUNCTION(stream_get_meta_data)main/streams/streams.c—php_stream_get_meta_datamain/streams/php_stream_temp.c— TEMP meta shape (no timed_out/blocked/eof)PHP implementation
ext/standard/JitStreamMetaThinAot.php(new)ext/standard/JitStreamMetaKernel.php— thin AOT branchtest/fixtures/aot/cases/stream_get_meta_data_memory.phptTest plan
var_export(bool)is Regression: AOT BackedEnum::tryFrom segfaults after build — VM/JIT match Zend (re-#24208, Zend/zend_enum.c) #26855):Observed AOT:
wt=PHP/st=MEMORY/mode=w+b/isset_mode=YESstream_get_meta_data_memory.phptmatches EXPECT (six1lines including TEMP)php vendor/bin/phpunit --filter StreamMetaKernelShrinkTest— OK (4 tests, 30 assertions)php script/check-selfhost-spine-coverage-sync.php— OKphp script/bootstrap-inventory.php --check— OK 7022/7022Not covered: full
ci-fast/ compliance suite;a+reported mode still hardcodesw+bunder thin AOT (done-when does not require it).Made with Cursor