Repository navigation
M5: bootstrap-selfhost-driver-smoke gate (#1521) - #2773
Merged
Merged
Conversation
Introduce make bootstrap-selfhost-driver-smoke to prove the native helloworld compile driver can emit and run compiler_smoke_standalone without Zend on the compile step. Harden vendor prelink with php-types fromDecl junk-fragment tolerance (#2743, #2745) and explicit PHP_COMPILER_VENDOR_PRELINK in the vendor-objects exec command. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make bootstrap-selfhost-driver-smoke— native helloworld compile driver emitscompiler_smoke_standalone.phpand runs gen-2 without Zend on the compile step (emit_path=native).php-types-fromdecl-junk-fragments.patchtolerates*//*doc-comment junk (bootstrap-vendor-prelink: php-types Type::fromDecl crashes on doc-comment fragments (Type.php:443) #2743, bootstrap-vendor-prelink: ircmaxell/php-cfg bundle compile blocked by php-types Unknown type declaration (*/ ) #2745); passPHP_COMPILER_VENDOR_PRELINK=1inbootstrap-vendor-objects.phpexec.BOOTSTRAP_M5_DRIVER_GATE=1inci-local.shllvm tail (default off).Test plan
./script/bootstrap-selfhost-driver-smoke.sh(Docker) — gen-2 stdoutcompiler smokevendor/bin/phpunit test/unit/BootstrapSelfhostDriverSmokeTest.php test/unit/PhpTypesFromDeclJunkFragmentsPatchTest.phpmake north-star5-verify --strict— vendor 3/3 object_ok (unchanged)Closes #1521. Related: #2743, #2745, #1492.
Made with Cursor