Repository navigation
Stdlib: AOT ParentIterator / MultipleIterator / RecursiveTreeIterator foreach (#27584) - #27672
Merged
Merged
Conversation
… foreach (#27584) Snapshot wrappers into __spl_ht with pure LLVM (no NestedJIT bridges), and route foreach through usesArrayIteratorHt so thin AOT matches Zend/VM. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParentIterator/MultipleIterator/RecursiveTreeIteratorinto__spl_htvia pure LLVM (NestedJIT HashTable bridges segfault under standalone AOT — peer Regression: AOT LimitIterator/AppendIterator fail — missing __generator_resume metadata (ext/spl/spl_iterators.c) #26825).VmIteratorForeach::usesArrayIteratorHt()so foreach walks the snapshot instead of falling through to a bad object→HT path (that was the ParentIterator segfault).ext/spl/spl_iterators.c— ParentIterator filter, MultipleIterator zip rows, RecursiveTreeIterator default prefixes.Test plan
vendor/bin/phpunit --filter spl_wrap_iterators_foreach— OK (1 test)php script/bootstrap-inventory.php --check— OK 7004/7004php script/check-selfhost-spine-coverage-sync.php— OKprelinked/bootstrap-gen0/Closes #27584
Made with Cursor