Repository navigation
Stdlib: AOT NoRewindIterator/InfiniteIterator foreach via HT+pos (#27583, #27568) - #27612
Merged
Merged
Conversation
, #27568) Thin AOT lacked Iterator protocol for these OuterIterator wrappers, so foreach was silently empty. Snapshot inner `__spl_ht`, walk via `__spl_iter_pos`, and keep NoRewind::rewind a no-op so a second foreach stays empty; Infinite next() wraps. Prefer Iterator protocol over SplOuterIteratorHt so rewind semantics hold. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoRewindIterator/InfiniteIteratorwas silently empty (rc=0) because thin AOT had no Iterator protocol wiring.__spl_ht, walk via__spl_iter_pos+ Iterator methods; keepNoRewindIterator::rewinda no-op so a second foreach stays empty;InfiniteIterator::nextwraps.SplOuterIteratorHtso rewind semantics hold (php-srcext/spl/spl_iterators.c).Closes #27583
Closes #27568
Test plan
a1a2a3(≥3 AOT runs)1,2,1,2,1vendor/bin/phpunit --filter 'norewinditerator_foreach|infiniteiterator_foreach'→ OK (2 AotTest)php script/bootstrap-inventory.php --check→ OK 6996/6996php script/check-selfhost-spine-coverage-sync.php→ OKci-fast/ compliance suite /north-star5-verify-fastMade with Cursor