Repository navigation
Fix AOT PhpToken::tokenize getTokenName (#27263) - #27327
Merged
Merged
Conversation
Register PhpToken JIT/AOT Call proxies and materialize tokenize() tokens so $t[1]->getTokenName() prints T_ECHO instead of failing at compile time. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 3, 2026
PurHur
added a commit
that referenced
this pull request
Aug 3, 2026
…10533) (#27334) Honest bootstrap-gen0-refresh-argv-driver rebuild — stamps live fingerprint 308230ea… after DateTimeZone::getName / PhpToken landed past #27329 squash (race). Functional smoke OK. No restamp-only. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call to undefined method object::gettokenname()forPhpToken::tokenize(...)->getTokenName().phptoken::{__construct,tokenize,gettokenname}JIT Call proxies; literaltokenize()materializesPhpTokenobjects;getTokenName()uses an inline id→name select-walk (peer GetClassRuntime).test/repro/aot_phptoken_gettokenname.php+ AOT fixture catalog entry; spine/inventory synced (6894/6894).php-src:
ext/tokenizer/tokenizer.c/tokenizer.stub.php— PhpToken OOP API.Test plan
T_ECHOvendor/bin/phpunit --filter AotRegressionFixtureCatalogTest→ OK (103 tests)php script/bootstrap-inventory.php --check→ OK 6894/6894php script/check-selfhost-spine-coverage-sync.php→ OKNot covered:
new PhpToken(...)still segfaults under thin AOT (separate from tokenize path); issue done-when is tokenize+getTokenName only.Made with Cursor