Repository navigation
Stdlib: AOT replaceChild after createElement without DomRegistry (#27216) - #27247
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createElementmaterializes LLVM-only nodes (no DomRegistry). The NestedJITreplaceChildbridge then segfaulted on unregistered objects.firstChild/parentNode/ element-nav LLVM slots like ParentNode::append; seedchildNodeslength when the slot was never set (Regression: AOT DOMDocument::replaceChild() segfaults after build — VM/JIT match Zend (ext/dom/node.c) #27216).ext/dom/node.c(dom_node_replace_child).Closes #27216
Test plan
1:b; AOT--repeat10/10php vendor/bin/phpunit test/aot/AotTest.php --filter dom_node_replacechild— OK 2 tests#27044live length repro stillbefore=2/after=3Verification transcript
Gate snapshot (pre-existing master, not this PR): inventory OK 6883/6883;
user_release_ready: no(helper-runtime prelink stale + north-star5-fast gen-0 mismatch).Made with Cursor