Stdlib: fix AOT hexdec/bindec NestedJIT insert and string ABI (#26884) - #26903
Merged
Merged
Conversation
Restore the IR insert block after mid-emit helper/bridge link, pass __string__* into phpc_basetozval_result, and parse digits with NestedJIT-safe recursion so AOT matches Zend for the issue repro (255/10). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Merged. Verification on this branch: |
This was referenced Aug 2, 2026
Closed
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MathBaseConverthelper/bridge link (same orphan-BB class as Regression: AOT http_build_query link fails — undefined __compiler_http_build_query (ext/standard/http.c) #26869) and skip bridge emit under NestedJIT.__string__*intophpc_basetozval_result(NestedJIT-safe ABI) instead ofi8*+stringFromCstr.while/VmMathdigit parse with substr recursion so AOThexdec('ff')/bindec('1010')match Zend (255/10).php-src reference
ext/standard/math.c—PHP_FUNCTION(hexdec)/PHP_FUNCTION(bindec)ext/standard/{hexdec,bindec,octdec,base_convert_}.php,MathBaseConvertJitHelper.php,lib/JIT/Builtin/MathBaseConvert{,Runtime}.phpTest plan
php vendor/bin/phpunit --filter 'MathBaseConvertRuntimeShrinkTest|HexdecBindecAot26884Test'→ OK (7 tests)php bin/compile.php -o /tmp/h26884on repro → prints255then10255/10./script/check-generated-docs.sh(Docker) → all generated docs in syncci-local/ overflow-to-float path forhexdec('FFFFFFFFFFFFFFFF')under NestedJIT (may still print0; follow-up if needed)Made with Cursor