Repository navigation
Self-host M5: unify helloworld emit-TU sidecars (#2666) - #2684
Merged
Merged
Conversation
Register compiler unit probe and compile_driver link-time sidecars in the compile_smoke_m3_emit branch so build/selfhost-helloworld-emit can native-emit inventory-scale probe sources without a dedicated emit entry. Regenerate bootstrap-inventory.md for the --check gate. bin/compile.php native emit remains blocked on real Compiler spine lowering (#2600); unit probe via unified helper is green in Docker. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler_unit_probe_compile.phpandcompile_driver.phplink-time AOT sidecars unconditionally in thecompile_smoke_m3_emitemit-log branch (same branch used byhelloworld_m3_emit_native_entry.php).build/selfhost-helloworld-emitnow native-emits the compiler unit probe (compile OK) without requiring the dedicated unit-probe emit binary orPHP_COMPILER_M3_COMPILER_UNIT_PROBE_EMITat link time.docs/bootstrap-inventory.mdsophp script/bootstrap-inventory.php --checkis green.Blocker (follow-up #2600)
bin/compile.phpstill returnsparseAndCompile returned nullvia the unified helper — host full AOT fails on vendorExpr_Closure; real Compiler spine pre-lower in the emit TU segfaults LLVM 9 (#2540).Test plan
BOOTSTRAP_M3_HELLOWORLD_STRICT=1 make bootstrap-selfhost-helloworld→emit_path=nativePHP_COMPILER_M3_SOURCE=test/selfhost/compiler_unit_probe/compiler_unit_probe_compile.php ./build/selfhost-helloworld-emit→compile OKphp script/bootstrap-inventory.php --checkbin/compile.phpnative emit (still red — Self-host M5: gen-1 binary compiles bin/compile.php spine (full driver, not loop smoke slice) #2600)Made with Cursor