Repository navigation
Self-host M5: fold PHP_COMPILER_LIB_SPINE_SMOKE for bin/compile.php AOT (#2600) - #2635
Merged
Merged
Conversation
…OT (#2600) cli_driver.php references this bundle-only constant; JIT now emits false outside self-host spine smoke instead of failing compile with unknown constant fetch. Next blocker for native bin/compile.php: Expr_Closure in vendor/cli path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHP_COMPILER_LIB_SPINE_SMOKEtotruein self-host spine bundles (PHP_COMPILER_SELFHOST_AOT=1) andfalsewhen compiling the realbin/compile.phpdriver (matchescli_driver.phpearly-return guard).Unknown constant fetch: PHP_COMPILER_LIB_SPINE_SMOKE).BootstrapAotJitCompileTest::testCliDriverLibSpineConstantFoldsForBinCompileDriverregression.Next blocker (#2600)
Native
bin/compile.phpAOT now fails atUnsupported expression: Expr_Closure(vendorcli_driver.php/ autoload path) — separate lowering work.Test plan
./script/docker-exec.sh -- bash -lc 'php bin/compile.php -o /tmp/t /tmp/lib_spine_const_test.php'(cli_driver pattern →driver)make bootstrap-selfhost-link/bootstrap-selfhost-compile-smoke-probe(emit_path=native)BootstrapAotJitCompileTest(LLVM group) when vendor/phpunit available on hostMade with Cursor