Self-host M2: promote bin/vm.php in spine smoke native link (#2134) - #2602
Merged
Conversation
Replace vm_run_smoke substitute with real bin/vm.php in compiler_lib_spine_smoke, skip src/cli argv includes during self-host AOT compile, and clear the native-link deferred list so M2 spine bundles the honest VM entry toward #2201. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/vm.phpintocompiler_lib_spine_smoke(replacingvm_run_smoke.phpsubstitute) with spine-safe CLI argv skip viaPHP_COMPILER_LIB_SPINE_SMOKE+cli_spine_shim.php.IncludeHelperforsrc/cli.php/src/cli_driver.php/vendor/autoload.phpso spine link avoidsExpr_Closurefrom the argv driver.bootstrap_spine_native_link_deferred()and update inventory/docs/tests for the last native-link deferral removal.Test plan
BOOTSTRAP_LIB_SPINE_SMOKE=1 make bootstrap-selfhost-lib-spine-smoke→compiler_lib_spine_smoke bundle OKBOOTSTRAP_LIB_SPINE_VM_SMOKE=1 make bootstrap-selfhost-lib-spine-vm-smoke→vm-spine-okBootstrapLibSpineVmSmokeTest,SelfhostSpineCoverageSyncTest,SelfhostSpineDeferredSyncTestCloses #2134
Made with Cursor