Repository navigation
Language: trait abstract residuals fatal at DECLARE after prior stmts (#25912) - #25922
Merged
PurHur merged 1 commit intoJul 31, 2026
Merged
Conversation
…#25912) Keep trait-using classes in source order and raise zend_verify_abstract_class as E_COMPILE_ERROR on stderr so echo-before-class matches php-src. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
class C { use Trait; }DECLARE opcodes in source order so preceding statements (e.g.echo "before") run before trait abstract residual checks — matches Zend bind timing (Zend/zend_inheritance.czend_verify_abstract_class).\CompileErrorand print viaraiseClassDeclareCompileFatal(PHP Fatal error:on stderr, exit 255).lib/Compiler.php,lib/VM/ClassValidator.php,lib/VM.php); no new C.Closes #25912
Test plan
./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_trait_abstract_unimplemented_fatal.php; php bin/vm.php test/repro/maintainer_gap_trait_abstract_unimplemented_fatal.php'VM: stdout
before; stderrPHP Fatal error: Class C contains 1 abstract method… (C::f); exit 255; noaccepted.vendor/bin/phpunit --filter TraitAbstractUnimplementedFatalTest— OK (2)vendor/bin/phpunit --filter trait_abstract_unimplemented_fatal test/compliance/VMTest.php— OK (1)trait_abstract_const|trait_abstract_private_ok|enum_trait_abstract— OK (4)Pre-claim gates:
user_release_ready: yes; inventory OK; north-star5-fast ok.Made with Cursor