Language: inaccessible isset/unset via __isset/__unset (#25668) - #25705
Merged
Merged
Conversation
) Declared private/protected slots were treated as present for isset/empty/unset from outside scope, skipping magic and leaking or clearing the real property. Match zend_std_has_property / zend_std_unset_property: overload or Error, keep in-scope and parent-private-from-child behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isset/emptyon declared private/protected props no longer reads the real slot; they dispatch__isset(or return false) perzend_std_has_property.unsetdispatches__unsetwithout clearing the private slot; without magic it throwsCannot access private/protected property …. Parent-private from a child stays a silent no-op (or__unset).magic_isset_inaccessible.phpt,magic_unset_inaccessible.phpt.Closes #25668
php-src reference
Zend/zend_object_handlers.c—zend_std_has_property,zend_std_unset_propertyPHP implementation
lib/VM.php—objectPropertyIsSet,dispatchInaccessibleDeclaredPropertyUnset(+ shareddeclaredPropertyInaccessibleFromCaller)Test plan
vendor/bin/phpunit --filter 'magic_isset|magic_unset' test/compliance→ OK (12 tests, VM+JIT)Verification transcript
Gates noted (master baseline)
north-star5-verify --fast/ inventory / VM probe: greenrelease-readiness:user_release_ready: no— helper-runtime prelink stale (unrelated)Made with Cursor