Stdlib: withhold ext/zip unless host or ENABLE (#25010) - #25040
Merged
Conversation
PROFILE=8.4 must not invent zip/ZipArchive/zip_open when host Zend lacks ext/zip. Functional PHPTs opt in via PHP_COMPILER_ENABLE_ZIP=1. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extension_loaded('zip')/ZipArchive/zip_*on hostextension_loaded('zip')or explicitPHP_COMPILER_ENABLE_ZIP=1— notPROFILE=8.4alone.Closes #25010
Test plan
PROFILE=8.4all false;ENABLE=1true ontest/repro/maintainer_gap_zip_phantom.phpvendor/bin/phpunit --filter 'VMTest.*extension_loaded_zip_phantom|ZipExtensionPolicyTest|ZipModuleTest|ziparchive_forward_profile|zip_procedural_basic'→ OK (10)php-src ref:
ext/zip/php_zip.c. PHP impl:ext/zip/ZipExtensionPolicy.php.Made with Cursor