Self-host M2: union-type parse + static array literal fold for spine smoke - #2504
Merged
Conversation
…ray literals Ensure php-cfg union-type patches run before AOT bootstrap compile (fixes #2499 spine smoke Unknown type node: UnionType). Extend function-local static lowering to fold list-style array literals at compile time for VmString::soundex (#2286). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php-cfg-union-type, etc.) automatically inci_apply_llvm_memory_env()so bootstrap/AOT gates no longer fail withUnknown type node: UnionTypewhenmake bootstrap-selfhost-lib-spine-smokeruns outside full CI.compileFunctionStaticVar()to fold list-style array literals (e.g.VmString::soundexlookup table) into compile-time constants, unblocking the next spine compile failure after union types.Test plan
BOOTSTRAP_LIB_SPINE_SMOKE=1 make bootstrap-selfhost-lib-spine-smoke→compiler_lib_spine_smoke bundle OKmake bootstrap-selfhost-link→ OK./script/bootstrap-loop-probe.sh --dry-run→ exit 0 (M2 prereq passes)vendor/bin/phpunit test/unit/UnionTypeParseTest.phpstatic $table = [0, '1', 2]returns012(withscript/apply-patches.sh)test/compliance/cases/language/static_local_array_literal.phptCloses #2499
Made with Cursor