Stdlib: Zend named params for hash_update_stream/html/ob (#23786) - #24963
Merged
Merged
Conversation
InternalArgInfo still labels hash_update_stream's 2nd arg handle; map stream (+ html/ob/hash_update) in BuiltinParamNames so Reflection and named calls match php-src stubs. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/BuiltinParamNames.phpforhash_update_stream(streamnot InternalArgInfohandle), plus durable maps forhash_update,get_html_translation_table, andob_get_status..phpt, andtest/repro/issue_23786_html_hash_ob_named.php.php-src reference
ext/hash/hash.stub.php—hash_update/hash_update_streamext/standard/html.stub.php/basic_functions.stub.php—get_html_translation_table/ob_get_statusTest plan
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/issue_23786_html_hash_ob_named.php'→ matches Zendvendor/bin/phpunit --filter testHtmlHashObNamedParamsResolve→ OK (15 assertions)vendor/bin/phpunit --filter "named_args_hash_update_stream|named_args_html_ob_status" test/compliance/VMTest.php→ OKJITTest.php→ OKnamed_args_hash_copy/named_args_hash_update_filestill greenVerification transcript
(VM and Zend identical.)
Not covered: full
ci-fast/ spine / north-star5 (pre-existing spine red forSoapHttpTransport.phpon master — unrelated).Made with Cursor