[PurHur]

Summary

• eval() of a child (or trait-using child) that overrides a parent final method now raises Zend-equivalent E_COMPILE_ERROR (Cannot override final method A::f()), matching same-script FinalMethodOverrideCheck.
• Runtime guard lives in inheritFromParent (php-src Zend/zend_inheritance.c), same pattern as final class consts (Regression: final class constants can be overridden by child class (re-#4455, Zend/zend_inheritance.c) #22329) and final properties (Regression: child can override final plain property on PROFILE=8.4 (re-#22339, Zend/zend_inheritance.c) #22988).
• PHP-in-PHP only — no C runtime changes.

Closes #24884

php-src reference

• Zend/zend_inheritance.c — final method override check
• Zend/zend_compile.c — compile-time inheritance for eval

Test plan

• Issue repro (VM fatal exit 255; try/catch does not swallow)
• Direct source compile still fatal via FinalMethodOverrideCheck
• Trait + grandparent eval paths
• Unit: FinalMethodOverrideCheckTest (6 cases)
• Compliance PHPT final_method_eval_override_fatal (VM); JIT skip pending MCJIT eval deferral (same as Regression: eval child redeclaration of final class const — silent abort, not Zend fatal (re-#22329, Zend/zend_inheritance.c) #22922/Regression: child can override final plain property on PROFILE=8.4 (re-#22339, Zend/zend_inheritance.c) #22988)

Verification transcript

$ php bin/vm.php /tmp/finaleval.php
PHP Fatal error:  Cannot override final method A::f() in /tmp/finaleval.php : eval()'d code on line 1
RC:255

$ php bin/vm.php test/repro/issue_24884_eval_final_method_override.php
PHP Fatal error:  Cannot override final method A::f() in ... : eval()'d code on line 1
RC:255

$ php vendor/bin/phpunit --filter 'final_method_eval_override_fatal|FinalMethodOverrideCheckTest'
OK (7 tests, 17 assertions)

Not covered: full ci-fast / JIT MCJIT eval inheritance (deferred like sibling cases).

Made with Cursor