Repository navigation
Fix: SPINE_CHUNK sockets compile past SIGSEGV/verify (#24429) - #24890
Merged
Merged
Conversation
Require TYPE_STRING on the compileTimeString IDENTICAL fast-path so VALUE boxes are not passed to VmStringCompare as native strings, and coerce `__object__*` returns through valuePtrFromVariable instead of storing a `__value__*` into alloca `__value__`. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_STRINGguard on Helper'scompileTimeStringIDENTICAL fast-path so VALUE-boxed string literals are not passed toVmStringCompare::identicalas native__string__*(was SIGSEGV /structGepkind=10 underPHP_COMPILER_SPINE_CHUNK=1onext/sockets/SocketsLibcThinAbi.php).__object__*returns viaJitValueBox::valuePtrFromVariableinstead ofstore __value__*into alloca__value__(module verify failure inSocketsLibcThinAbi::ffi()after the string-compare crash was cleared).test/repro/issue_24429_static_nullable_object_return.php.Closes #24429 — partial: removes the sockets SIGSEGV/verify wall for
SocketsLibcThinAbi; fullext/socketschunk still OOMs at ≥4G (next capacity wall), and unbound ExternalMethod stubs remain (#579).php-src / prior art
1a719cbe6(bootstrap-aot-link: VALUE-box concat + ordered float compare lowering #8555 getenv/compileTimeStringnarrowing).JitValueBox::valuePtrFromVariable(already handles KIND_VALUE__value__*).Test plan
Not covered
static ?objectreturns (pre-existing abort on master; separate)Made with Cursor