Repository navigation
Fix highlight_string() HTML wire format to match Zend (#24662) - #24750
Merged
Merged
Conversation
- Wrapper: <code><span> instead of <pre><code> - Spaces: instead of literal space - Newlines: <br /> instead of literal newline php-src ref: Zend/zend_highlight.c — token HTML emission Closes #24662 Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Jul 29, 2026
Default 8.4.0-dev emits PHP 8.3+ <pre><code> with literal whitespace; PROFILE=8.2 keeps the legacy <code><span>/ shape from #24750. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<pre><code style=...>to<code><span style=...>matching Zend (Zend behavior)<br />(Zend behavior)php-src reference
Zend/zend_highlight.c— token HTML emission formatVerification
Not covered: full token color parity;
highlight_fileconsistency (shares the same engine).Closes #24662
Made with Cursor