Release: baseline + quarantine tooling to make the sharded suites a gate (Phase 1.3/1.4) - #24469
Merged
Merged
Conversation
…ate (Phase 1.3/1.4) #24445 made VMTest runnable in shards. Runnable is not a gate: neither suite is green (~400 pre-existing failures), so "did it fail?" is always yes. The gate is the SET DIFFERENCE of failing case NAMES against a committed baseline (AGENTS.md §2). This adds that. script/compliance-baseline.sh --collect --suite=VMTest # shards -> test/compliance/baselines/ script/compliance-baseline.sh --diff --suite=VMTest # current shards vs committed baseline Two guards, both validated by making them fire: INCOMPLETE refuses a partial shard set. Diffing 3 of 24 shards reports every unrun case as newly-passing, which reads as a large improvement. Verified: "INCOMPLETE — 1 of 400 shards have results", exit 2. MIXED refuses results from different --shards=N runs in one directory. The union would double-count some cases and omit others, and the coverage check would compare against whichever N sorted first. Verified: "MIXED shard widths present (16,8)", exit 2. test/compliance/quarantine.txt is added EMPTY on purpose. RELEASE-PLAN Phase 1.4 names hrtime_*, proc_get_status_basic, interface_abstract_static_call and dnf_return_type_error as suspected flaky, but suspicion is not measurement: quarantining a case on reputation hides real regressions in it. Each needs two full runs of ONE commit showing it on one side and not the other before it is listed. The file documents that, and that entry is a bug rather than a resting place. Quarantined names are excluded from BOTH sides of the diff, because a flaky case in a baseline manufactures phantom regressions — already demonstrated twice: an e08_spread "regression" that was 17/30 vs 17/30 noise, and two sweeps of the same master disagreeing about k06/m04 (#24388). No baseline data yet: the full 24-shard VMTest run is ~2-3h on this box (one container at a time, since concurrent containers sharing the bind mount corrupt each other's caches) and is still running. The tooling refuses to produce a baseline from the partial results, which is the point. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24445. Sharding made
VMTestrunnable; this makes it a gate.Why runnable isn't enough
Neither suite is green —
VMTestcarries ~400 pre-existing failures — so "did it fail?" is alwaysyes and carries no information. The gate is the set difference of failing case names against a
committed baseline (AGENTS.md §2).
Two guards, both validated by making them fire
INCOMPLETEMIXED--shards=Nruns cannot be unioned; some cases double-count, others vanishI test guards by breaking them because a guard that cannot fail is the recurring failure mode in this
repo — including in my own
shard-compliance.shlast iteration, wheregrep -c … || echo 0silently disabled the zero-executed check.
The quarantine file is deliberately empty
Phase 1.4 names
hrtime_*,proc_get_status_basic,interface_abstract_static_callanddnf_return_type_erroras suspected flaky. Suspicion is not measurement. Quarantining a case onreputation hides any real regression in it, so each needs two full runs of one commit showing it on
one side and not the other before being listed.
The file documents that policy, and that entry is a bug to fix rather than a resting place.
Quarantined names are excluded from both sides of the diff, because a flaky case in a baseline
manufactures phantom regressions. That has already cost real time twice: an
e08_spread"regression" that turned out to be 17/30 vs 17/30 noise, and two sweeps of the same master
disagreeing about
k06/m04(#24388).No baseline data in this PR
The full 24-shard
VMTestrun takes ~2–3 h on this box — one container at a time, since concurrentcontainers sharing the bind mount corrupt each other's caches — and is still running.
The tooling refuses to produce a baseline from partial results, which is exactly the behaviour
that makes it trustworthy. The data lands in a follow-up once a complete run exists, and ideally
after a second run confirms which cases flip.