Repository navigation
Conversation
Register NestedJIT HashTableShiftFirst and call it from ArrayShiftRuntime so e30_array_lit_dim_assign_shift compiles again (third #23974-style gap). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Closing as duplicate of #24046 ( This branch was the same lane continuing WIP; lost the merge race. Verified independently before push: e30 compiles; shift semantics match Zend without json_encode (master still segfaults on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e30_array_lit_dim_assign_shift(Call to undefined method HashTable::shiftfirst()), third instance of the AOT: Exception::getCode() and two HashTable methods missing at build time (array_slice, implode+array_map) #23974 NestedJIT registration gap.HashTableShiftFirstLLVM Call and routesArrayShiftRuntimethrough it (no NestedJIT ofArrayShiftJitHelperfor standalone AOT).shiftfirstonNestedVmHashTableMethodLlvm+ spine require; refreshes inventory.Test plan
php bin/compile.php -o /tmp/e30 test/differential/cases/e30_array_lit_dim_assign_shift.php→ COMPILE:0 (was undefined method)json_encode:$a[0]=99; array_shift($a)→ shift returns99, remaining2,3(matches Zend)php vendor/bin/phpunit --filter 'NestedVmHashTableMethodLlvmTest|ArrayShiftRuntimeShrinkTest'→ OK (5 tests)php script/bootstrap-inventory.php --check→ OK 6599/6599php script/check-selfhost-spine-coverage-sync.php→ OKNot covered / known master noise:
json_encode(1)AOT segfaults on master; e30 still crashes at run for that reason (compile gap closed). Dim-assign expression result$x = ($a[0]=99)also empty under AOT on master (pre-existing).Closes #24025
Made with Cursor