Repository navigation
AOT: array_map string builtins + implode variable arrays (#23974) - #24013
Merged
Merged
Conversation
Thin-standalone NestedJIT of ArrayMapJitHelper segfaulted on foreach/ VmInternalCall; lower null and compile-time string callbacks via ArrayMapLlvm (Internal::call loop). implode() now loads haystacks through ArrayBuiltinHelper so KIND_VARIABLE locals are not passed as garbage __hashtable__* pointers. e23_implode matches Zend 10/10. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e23_implodeAOT now matches Zend (x-y/X, Y).ArrayMapLlvm: pure LLVM forarray_map(null|compile-time-string)(NestedJIT ofArrayMapJitHelpersegfaulted on foreach /VmInternalCallunder thin standalone).implode::loadHaystackusesArrayBuiltinHelper::loadHashTableso KIND_VARIABLE locals are not passed as garbage__hashtable__*(crash was in__hashtable__getNumElements).exportKeyValuePairsfor NestedJIT-safe foreach; spine + inventory includeArrayMapLlvm.php.Test plan
script/differential-sweep.sh --aot --dir <e23> --repeat 10→ok e23_implode.php (10/10 runs)array_map("strtoupper", …),array_map("strval", …),$a=[…]; implode("-", $a)— 5/5 eachg04_exception_stateAOT still green (3/3)php vendor/bin/phpunit --filter ArrayMapRuntimeShrinkTest|ArrayMapCallbackPolicyTestphp script/bootstrap-inventory.php --check→ OK 6600/6600php script/check-selfhost-spine-coverage-sync.php→ OKNot covered
differential-sweep.sh --aotcorpus;e16_array_slicestill blocked onprint_r(AOT: var_dump() aborts (SIGABRT) with no diagnostic — even var_dump(7) #23540), not missingsliceCopyarray_mapstring-builtin NestedJIT bridge (still helper path)north-star5-verify --strictMade with Cursor