Repository navigation
AOT: inline str_pad helper — stop NestedJIT VmString null segfault (#23911) - #23931
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StrPadJitHelpercalledVmString::strPad(), which returns null under user-script AOT and segfaults (same class as Regression: str_repeat Reflection names input/mult — Zend string/times; named args rejected (ext/standard/string.c) #23204str_repeat).StringStrPadwith theNestedJitCompileScopepeer guard used byStringStrRepeat.Closes #23911
php-src reference
ext/standard/string.c—PHP_FUNCTION(str_pad)ext/standard/StrPadJitHelper.php+lib/JIT/Builtin/StringStrPad.phpTrust gate (pre-claim)
bootstrap-inventory --check: OK 6592/6592release-readiness --json:user_release_ready: yes(north-star5-fast ok; gen-0 seed stale warning only)Verification
Not covered: full
differential-sweep.sh --aot;str_pad_null_forward_profile_84AOT fixture still expects exit 255 while VM/AOT soft-null on PROFILE=8.4 (pre-existing vs #21190) — unchanged by this PR.Made with Cursor