AOT: fix concat ephemeral temp lifetime for dead echo/call operands (#23798) - #23827
Merged
Conversation
…nds (#23798) Dead php-cfg Concat temps (echo/call args) were lowered in-place into scope slots that alias the left operand, corrupting the local on a second concat. Route dead operands through a dedicated entry alloca instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve TYPE_CONCAT conflict: keep ephemeral alloca path and thread left/right operands into compileConcatIntoNewString (master API). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concattemporaries (echo/call args) were lowered in-place into scope slots that can alias the concat left operand, corrupting the local on a second concat from the same variable.deadOperandsthroughassignEphemeralConcatOperand: fresh__string__*in a dedicated entry alloca (KIND_VARIABLE) instead of in-place CONCAT or bareKIND_VALUErvalues.echo $s.'1'; echo $s.'2';.Verification
Not run:
script/differential-sweep.sh --aot(VM unaffected per issue), bootstrap/self-host gates (no compile-spine change).Closes #23798
Made with Cursor