Pillar 1: sync spine for IncDecResourceProvenance (#23483) - #23797
Merged
Merged
Conversation
Add the new JIT provenance helper to compiler_lib_spine_smoke so spine coverage and north-star5-verify-fast pass again after inventory grew to 6587. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 27, 2026
PurHur
added a commit
that referenced
this pull request
Jul 27, 2026
#23794 / #23797 added IncDecResourceProvenance to the spine but left ext/standard/JitOpenStreamHandles.php (php://memory fopen table for AOT ++/-- resource guards) off the bundle. spine-sync --no-link restores 6588/6588 coverage so release-readiness spine + north-star5-fast pass. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/IncDecResourceProvenance.phptotest/selfhost/compiler_lib_spine_smoke/main.php— it landed in bootstrap inventory (Perf: generated code is 4-14x SLOWER than Zend on basic loops and calls #23483 perf work) but was missing from the M5 spine bundle.spine-sync --no-link.Problem
release-readiness.sh --jsonreporteduser_release_ready: nowith two Pillar 1 failures:spine-coverage:lib/JIT/IncDecResourceProvenance.phpmissing from spinenorth-star5-fast: blocked on spine-coverage-syncTest plan
Not covered: gen-0 sidecar relink (
make bootstrap-gen0-refresh-sidecar) — stamp still stale; intentional--no-linkspine-sync only.Relates to #23483, #10533 (Pillar 1 trust).
Made with Cursor