[PurHur]

Summary

• Regression: highlight_string() HTML still lacks Zend <pre> wrapper / uses nbsp (re-#10308, ext/standard/highlight.c) #23733 — highlight_string() / highlight_file() / show_source() now emit Zend 8.4 <pre><code style="color: #000000"> wrapper with literal spaces (no  , no <br /> newline conversion).
• Stdlib: assert() failure warns E_USER_WARNING "Assertion failed" — Zend E_WARNING "assert(): … failed" (ext/standard/assert.c) #23731 — Failing assert() with assert.exception=0 now reports E_WARNING (2) and message shape assert(): … failed instead of E_USER_WARNING / Assertion failed: …. VM + JIT paths updated.

php-src reference

• ext/standard/highlight.c / php_highlight.h — HTML emitter (Regression: highlight_string() HTML still lacks Zend <pre> wrapper / uses nbsp (re-#10308, ext/standard/highlight.c) #23733)
• ext/standard/assert.c — assert_handle_failure warning channel (Stdlib: assert() failure warns E_USER_WARNING "Assertion failed" — Zend E_WARNING "assert(): … failed" (ext/standard/assert.c) #23731)

Verification

# highlight_string byte-match vs php:8.4-cli
php bin/vm.php -r 'echo highlight_string("<?php echo 1;", true), "\n";'
docker run --rm -i --entrypoint php php:8.4-cli -r 'echo highlight_string("<?php echo 1;", true), "\n";'
# → identical output

# assert warning repro
php bin/vm.php -r 'ini_set("zend.assertions","1"); ini_set("assert.exception","0"); error_reporting(E_ALL); set_error_handler(fn($n,$s)=>print("W:$n:$s\n")?:true); assert(false,"x");'
# → W:2:assert(): x failed

./script/phpunit.sh --filter 'highlight_string_pre_wrapper|assert_warning_parity|highlight_file_multiline_br|highlight_file_br'
# → OK (8 tests, 8 assertions)

Closes #23733
Closes #23731

Made with Cursor