AOT: fix uncaught fatals and try/catch getMessage/AFTER (#23641) - #23652
Merged
Merged
Conversation
Seed Throwable layout + ExceptionConstruct for user-script AOT, print Zend-shaped uncaught fatals instead of abort, and keep catch arms from emitting an early returnVoid so merge/AFTER runs. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep only the issue uncaught/caught/caught-no-msg scripts. Co-authored-by: Cursor <cursoragent@cursor.com>
Propagate TYPE_NEW startLine into callSiteLine and store AOT entry path on construct so uncaught fatals print a real file:line. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 27, 2026
AOT: exceptions are broken — caught blocks abort, getMessage() empty, uncaught prints nothing
#23641
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHP Fatal error: Uncaught …and exit 255 (was silent abort / rc=134).getMessage()and continue to code aftertry(AFTER).ExceptionConstructfor user-script AOT; catch arms setsyntheticCfgBranchso void-main does not early-returnVoid.php-src:
Zend/zend_exceptions.c— uncaught printer / default exception construct. PHP implementation:lib/JIT/Builtin/UncaughtThrowPrinter.php,lib/JIT/Call/ExceptionConstruct.php,Object_::seedThrowableExternalClass,TryCatchHelper/compileCatchArmAtEntry.Test plan
php script/check-selfhost-spine-coverage-sync.php→ OKphp script/bootstrap-inventory.php --check→ OK 6583/6583 (after regen)ci-local/ differential-sweep--aot(scoped language fix)Made with Cursor