Bootstrap: literal ZLIB encoding defaults unblock gen-0 spine (#23468) - #23646
Merged
Merged
Conversation
Global ZLIB_ENCODING_* param defaults abort honest Zend gen-0 refresh at VmZlib (#3803). Match the VmGd GD2 literal-default pattern so spine AOT can fold encoding args. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 27, 2026
PurHur
added a commit
that referenced
this pull request
Jul 27, 2026
Prevent HashTable->$add from dispatching to OutputRewriteVarsJitHelper::add during gen-0 argv AOT. Guard VmZlib literal encoding defaults (#23646). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Jul 27, 2026
Prevent HashTable->$add from dispatching to OutputRewriteVarsJitHelper::add during gen-0 argv AOT. Guard VmZlib literal encoding defaults (#23646). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-harness-phpc-gen0-23468-r1failed at ~47% (ext/standard/VmZlib.php) withParameter default must be a compile-time constant (#3803): $encoding.\ZLIB_ENCODING_{DEFLATE,RAW,GZIP}param defaults inVmZlib/VmZlibCorewith numeric literals15/-15/31(same pattern as VmGd GD2 defaults for Gen-1+ #1492: committed gen-0 seed cannot be rebuilt — refresh OOMs at 48 GiB, 44 restamps since the blob last changed (script/bootstrap-refresh-gen0-sidecar.sh) #22642).VmGdGd2LiteralDefaultsTest.Refs #23468 (unblocks honest spine rebuild; argv driver publish still needed for Closes).
Test plan
vendor/bin/phpunit --filter VmZlibLiteralEncodingDefaultsTest→ OK (2 tests)parseAndCompileFile(VmZlib.php)/VmZlibCore.php→ non-nullBOOTSTRAP_GEN0_REFRESH_ARGV_DRIVER=1 ./script/bootstrap-gen0-refresh-exclusive-docker.shafter merge./script/bootstrap-gen0-driver-functional-smoke.shgreen → then Closes Bootstrap: committed gen-0 driver cannot compile anything — every input fails at parseAndCompile #23468Verification
Made with Cursor