Perf: per-unit helper-runtime deps so JIT edits do not flush the corpus (#23458) - #23493
Merged
Merged
Conversation
…us (#23458) Narrow the global cache key to composer.lock/patches/LLVM, record deps[] on each unit (NestedJIT paths + one-level same-dir SSOT refs), and migrate the committed 257 manifests to v2 without re-emitting objects. Editing VmString invalidates ~42 units; editing lib/JIT.php invalidates none. Gen-0 fingerprint restamped unverified (driver bytes unchanged; #22642). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer.lock, patches, LLVM path) — notlib/JIT.php/Context.php/Runtime.php.--migrate-deps(rewrote JSON only;.o/.bcbytes unchanged).lowering_source_fingerprintrestampedunverified-restampafterHelperRuntimeCache.phpedit (driver sha/size unchanged; same pattern as Trust: restamp gen-0 fingerprint after lowering drift (#10533) #23473 / Gen-1+ #1492: committed gen-0 seed cannot be rebuilt — refresh OOMs at 48 GiB, 44 restamps since the blob last changed (script/bootstrap-refresh-gen0-sidecar.sh) #22642).Verification
Dep-count histogram after migrate: mostly 1–5 deps/unit (max 17). Editing one lowering no longer invalidates the whole corpus.
Test plan
php script/check-helper-runtime-prelink.php→ 257 freshHelperRuntimeCacheFingerprintTestmake north-star5-verify-fastMade with Cursor