Bootstrap: literal GD2 defaults so Zend spine AOT can pass VmGd (#22642) - #23081
Merged
Merged
Conversation
VmGd.php sorts before VmGdGd.php in the spine, so cross-class VmGdGd::GD2_* parameter defaults are not foldable under incremental AOT (#3803) and aborted exclusive refresh r18. Use matching literals. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Merged Post-merge: Pillar 1 still red on master ( #10533 comments are locked (2500+); trust probe lives on this PR + #22717. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/gd/VmGd.phpwith#3803(VmGdGd::GD2_CHUNKSIZE/GD2_FMT_RAWparameter defaults).VmGd.phpbeforeVmGdGd.php, so cross-class const defaults are not foldable under incremental AOT.128/1) and guard withVmGdGd2LiteralDefaultsTest.Continues in-flight pillar-1 work from #22717 / closed #22642 (Lane A: no eligible
languageIR issues this run; stdlib/ext queue is owned elsewhere).Refs #22642 · #10533 (pillar 1 / north-star5-fast)
Verification
Test plan
VmGdGd2LiteralDefaultsTestparseAndCompileFile(ext/gd/VmGd.php)OKVmGd.php(expect later cross-unit#3803or OOM — not this file)Made with Cursor