Language: hide SensitiveParameterValue from json_encode/var_export (#23042) - #23080
Merged
PurHur merged 1 commit intoJul 25, 2026
Merged
Conversation
…23042) Match Zend: private readonly $value plus empty VAR_EXPORT property bag so json_encode/var_export no longer leak secrets from #[\SensitiveParameter] wrappers. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 25, 2026
Bootstrap: unblock gen-0 spine refresh — docblock, ghost require, exclusive launcher (#22642)
#22717
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SensitiveParameterValue::$valueprivate readonly (Zendzend_exceptions.stub.php) sojson_encodeemits{}.var_export(get_properties_forVAR_EXPORT parity) and empty(array)cast.Closes #23042
Gate snapshot (pillar 1)
bootstrap-inventory --checkrelease-readiness --jsonuser_release_ready: yesnorth-star5-verify --fastTest plan
php bin/vm.php test/repro/sensitive_parameter_value_json_var_export.php→json={}/ empty__set_state/getvalue=secretphp bin/jit.php test/repro/sensitive_parameter_value_json_var_export.php→ samevendor/bin/phpunit --filter SensitiveParameter→ OK 27 testsVerification
php-src ref:
Zend/zend_exceptions.c/ SensitiveParameterValue — export/json must not expose backing store.PHP impl:
lib/VM/SensitiveParamSupport.php,lib/VM.phpvar_export bag,lib/VM/CastSupport.php.Made with Cursor