Repository navigation
Language: emit implicit-nullable E_DEPRECATED on file compile (#22987) - #22991
Merged
PurHur merged 1 commit intoJul 25, 2026
Merged
Conversation
File-level parseAndCompile runs before VM::running() is set, so the 8.4 deprecation only fired for eval. Wire Runtime's VMContext into the Compiler and emit via that path so main scripts match Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseAndCompile/bin/vm.phpunderPHP_COMPILER_PROFILE=8.4now emits Zend 8.4 implicit-nullableE_DEPRECATED(previously onlyeval()did, via Language: implicit nullable parameter (int $x = null) missing E_DEPRECATED on PROFILE=8.4 (Zend/zend_compile.c) #21390).maybeEmitImplicitNullableParamDeprecationrequiredVM::running(), which is unset untilRuntime::run(). WireRuntime'sVMContextintoCompilerand emit through that path.implicit_nullable_parameter_file_deprecated_profile84.phpt(main-file compile +--INI-- error_reporting=E_ALL).Closes #22987
php-src reference
Zend/zend_compile.c—zend_compile_params/ deprecate-implicitly-nullable-typeslib/Compiler.php,lib/Runtime.phpVerification
Trust gates (pre-claim)
bootstrap-inventory --check: OK 6518/6518release-readiness --json:user_release_ready=no—north-star5-fastred (gen-0 manifest/driver mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713); unrelated to this language fixvm-driver-probe: okTest plan
-d error_reporting=E_ALLMade with Cursor