Repository navigation
Language: gate pipe operator |> on PROFILE≥8.5 (#22792) - #22809
Merged
Merged
Conversation
|> is PHP 8.5-only in Zend; PROFILE=8.4 and the reference profile must parse-error like php-src. Keep desugar under PHP_COMPILER_PROFILE=8.5. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompilerVersion::supportsPipeOperator()onlanguageProfileVersion() >= 8.5.0(was 8.4.0) so|>matches Zend/php-src (PHP 8.5-only).PHP_COMPILER_PROFILE=8.4/ reference profile: Zend-shaped parse error;PROFILE=8.5still desugars.pipe_operator_profile84_reject.phpt.Closes #22792
php-src:
Zend/zend_language_parser.y(ZEND_AST_PIPE, 8.5+). PHP impl:lib/CompilerVersion.php,lib/PipeOperatorSyntaxRejector.php,lib/Ast/PipeOperatorDesugar.php.Test plan
vendor/bin/phpunit --filter CompilerVersionGateTest::testSupportsPipeOperator→ OK 3vendor/bin/phpunit --filter PipeOperatorReferenceProfileTest|PipeOperatorSyntaxRejectorTest→ OKvendor/bin/phpunit --filter pipe_operator test/compliance/VMTest.php→ OK 3 (forward 8.5, profile84 reject, reference reject)Pillar 1 note:
user_release_ready=noon master (spine/xmlrpc drift + stale gen-0 #22642); this PR is Pillar 4 language only.Made with Cursor