Repository navigation
Stdlib: xmlrpc encode_request/decode_request/type helpers (#22254) - #22807
Merged
Merged
Conversation
…pe (#22254) Register client/request and type helpers beside encode/decode under XmlrpcExtensionPolicy. PHP-in-PHP via VmXmlrpc; set_type uses a typed struct marker so encode/get_type survive by-ref call sites. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 24, 2026
Closed
PurHur
added a commit
that referenced
this pull request
Jul 24, 2026
…#22812) #22807 added xmlrpc_* request/type helpers to the vm.php inventory without compiler_lib_spine_smoke coverage; release-readiness regenerated the inventory doc then failed spine-coverage / north-star5-fast. Also restamp lowering fingerprint after concurrent master drift (#8713). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmlrpc_encode_request,xmlrpc_decode_request,xmlrpc_is_fault,xmlrpc_get_type,xmlrpc_set_typebehindXmlrpcExtensionPolicy(same gate as encode/decode).VmXmlrpc(php-in-PHP; noruntime/*.c).set_typestores a struct marker (__xmlrpc_type__) so by-ref sites keep the typed payload for encode/get_type.php-src: historic
ext/xmlrpc/xmlrpc-epi-php.c(removed in 8.0; PECL successor).PHP:
ext/xmlrpc/VmXmlrpc.php+ new builtins;lib/BuiltinByRefParams.phpfor&$method/&$value.Closes #22254
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_22254_xmlrpc_request_types.php— all symbols true; method=demo.add; params_ok; is_faultPHP_COMPILER_PROFILE=8.4 phpunit --filter xmlrpc_request_type_helpers— OKMade with Cursor