php-in-php: StringHex2bin NestedJIT via JitVmHelperLink (#22746) - #22748
Merged
Merged
Conversation
Route Hex2binJitHelper compile through JitVmHelperLink::ensureCompiled (peer #22701) so user-script env clearing and insert-block restore are shared; drop hand-rolled NestedJitCompileScope::run. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hex2binJitHelperNestedJIT compile throughJitVmHelperLink::ensureCompiled/lookupCompiled(peer php-in-php: StringUtf8Latin1 NestedJIT → JitVmHelperLink::ensureCompiled (#1492) #22701 StringUtf8Latin1).NestedJitCompileScope::run+parseAndCompile+new JIT()fromStringHex2bin.Hex2binRuntimeShrinkTestto guard the shared link path.C / lines:
lib/AOT/runtime/already has zero*.c(#17148). Net -15 lines inStringHex2bin.php(hand-rolled NestedJIT bridge deleted).Closes #22746
Test plan
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/Hex2binRuntimeShrinkTest.php'→ OK (4 tests, 19 assertions)make bootstrap-selfhost-vm-driver-execute-probe→ OKVerification transcript
php-src ref:
ext/standard/string.c—PHP_FUNCTION(hex2bin)(semantics unchanged; compile-path only).Made with Cursor