Stdlib: withhold grapheme_levenshtein() — Zend never ships it (#22661) - #22677
Merged
Merged
Conversation
Match php-src grapheme.stub.php / mb_ucwords phantom gate: always-false supports/advertises so function_exists stays false on every profile. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grapheme_levenshtein()on every profile (supportsGraphemeLevenshtein/advertisesGraphemeLevenshteinalways false), matching Zend/php-src (ext/intl/grapheme/grapheme.stub.phphas no entry; Feature request: levenshtein with multibyte support php/php-src#10180 never landed).mb_ucwordsphantom gate (Regression: mb_ucwords() phantom on PROFILE=8.4 — Zend 8.4/8.5 function_exists false (re-#20799, ext/mbstring) #21458): keep Internal +VmGrapheme::levenshteinfor unit tests, do not register forfunction_exists.php-src reference:
ext/intl/grapheme/grapheme.stub.phpPHP impl:
lib/CompilerVersion.php,ext/intl/Module.phpTest plan
php bin/vm.php test/repro/maintainer_gap_grapheme_levenshtein_phantom.php→okPHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_grapheme_levenshtein_phantom.php→okPHP_COMPILER_HELPER_RUNTIME_O=1 php bin/compile.php -o /tmp/glev_phantom … && /tmp/glev_phantom→ok(default + PROFILE=8.4)./script/phpunit.sh --filter grapheme_levenshtein→ OK (6 tests)./script/check-generated-docs.sh→ OK after matrix/inventory regenGate probe (this run)
--check: OK 6454/6454release-readiness --json:user_release_ready: no(north-star5-fast 4f-m gen-0 fingerprint mismatch — master/Gen-1+ #1492: committed gen-0 seed cannot be rebuilt — refresh OOMs at 48 GiB, 44 restamps since the blob last changed (script/bootstrap-refresh-gen0-sidecar.sh) #22642 class; not this PR)bootstrap-selfhost-link: red on master (LLVM module verify / stale gen-0) — unrelatedMade with Cursor