Repository navigation
Fix var_export($domProp, true) after @ silence misbind (#21975) - #22198
Merged
Merged
Conversation
Tighten the #15916 error-suppress ConstFetch fold guard to arg #0 only so trailing return-mode true after a sibling PropertyFetch still folds; restamp gen-0 lowering fingerprint for north-star5-fast. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-21975-var-export-dom-prop
branch
from
July 22, 2026 13:05
b93eb09 to
9709924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#15916guard intryFoldHoistedBoolNullLiteralCallArgrejected folding trailingtruewheneverproducerOrdinal === 0inside an@end-block. After@$d->loadHTML(...),var_export($domProp, true)left PropertyFetch mapped to arg1 and arg0 as a stale EXEC_RETURN (true/NULL).argIndex === 0(preservevar_export(@get_cfg_var(...), true)).lowering_source_fingerprintsonorth-star5-faststays green.Closes #21975
php-src reference
ext/standard/var.c—PHP_FUNCTION(var_export)ext/dom/php_dom.cread handlers (repro only)PHP implementation
lib/Compiler.php—tryFoldHoistedBoolNullLiteralCallArgerror-suppress guardTest plan
./script/phpunit.sh --filter 'var_export_dom_prop_return_true|get_cfg_var_display_errors|ErrorSuppressInlineReturnSlot'php script/check-bootstrap-gen0-manifest-sync.php→ OKmake north-star5-verify-fast→ OK./script/release-readiness.sh --json→"user_release_ready": "yes"Verification transcript
Made with Cursor