Skip to content

Stdlib: ReflectionFunction::isVariadic() returns Attribute-style flag (#22045) - #22079

Merged
PurHur merged 3 commits into
masterfrom
agent/issue-22045-reflection-function-is-variadic
Jul 22, 2026
Merged

PurHur merged 3 commits into
masterfrom
agent/issue-22045-reflection-function-is-variadic

Conversation

@PurHur

@PurHur PurHur commented Jul 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

php-src reference: ext/reflection/php_reflection.c — zim_reflection_function_abstract_isVariadic

Closes #22045

Test plan

  • Zend vs VM: test/repro/maintainer_gap_reflection_function_is_variadic.php
  • JIT: php bin/jit.php test/repro/maintainer_gap_reflection_function_is_variadic.php
  • Compliance: reflection_function_is_variadic.phpt (VM+JIT via phpunit)
  • Inventory 6341/6341 + spine coverage + sidecar stamp sync

Verification transcript

$ php bin/vm.php test/repro/maintainer_gap_reflection_function_is_variadic.php
f_variadic=true
g_variadic=false
f_params=3
f_required=1
closure_variadic=true
method_variadic=true
call_user_func=true
strlen=false

$ php bin/jit.php test/repro/maintainer_gap_reflection_function_is_variadic.php
(same)

$ php vendor/bin/phpunit --filter reflection_function_is_variadic
OK (2 tests, 2 assertions)

$ php script/bootstrap-inventory.php --check
OK 6341/6341

PurHur and others added 3 commits July 22, 2026 07:11
Expose isVariadic() for free functions/closures/internals (VM + JIT/AOT)
via zim_reflection_function_abstract_isVariadic semantics, sibling of #18228.

Co-authored-by: Cursor <cursoragent@cursor.com>
Register the builtin, JIT proxies/construct/getName, compile-time variadic
lookup table, spine coverage, and inventory sync.

Co-authored-by: Cursor <cursoragent@cursor.com>
…dic (#22045)

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur force-pushed the agent/issue-22045-reflection-function-is-variadic branch from 0fd2d5f to 471a54a Compare July 22, 2026 07:13
@PurHur
PurHur merged commit 06f5909 into master Jul 22, 2026
1 check failed
@PurHur
PurHur deleted the agent/issue-22045-reflection-function-is-variadic branch July 23, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: ReflectionFunction::isVariadic() missing — ReflectionMethod works (ext/reflection/php_reflection.c, sibling #18228)

1 participant