Repository navigation
Stdlib: ReflectionAttribute::getTarget() returns Attribute::TARGET_* (#22044) - #22060
Merged
Merged
Conversation
3 tasks
…22044) Store the declaration-site TARGET_* bitmask on ReflectionAttribute and expose getTarget() on VM/JIT to match php-src zim_reflection_attribute_getTarget. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-22044-reflection-attribute-get-target
branch
from
July 22, 2026 06:02
8e2c8ef to
8d3fc3a
Compare
This was referenced Jul 22, 2026
PurHur
added a commit
that referenced
this pull request
Jul 22, 2026
…) (#22075) Emergency stamp: master lib/ext moved after the last fingerprint stamp, re-breaking north-star5-fast 4f-m (manifest 8b4e4f06… vs live d22247bd…). Honest blob rebuild still deferred; spine sidecar SHA already matches. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReflectionAttribute::getTarget()(VM + JIT) returning the declaration-siteAttribute::TARGET_*bitmask, matching php-srczim_reflection_attribute_getTarget.AttributeRegistry/ parameter getAttributes; JITgetAttributespaths set$targetwhen allocatingReflectionAttribute.php-src reference:
ext/reflection/php_reflection.c—zim_reflection_attribute_getTarget;Zend/zend_attributes.h—ZEND_ATTRIBUTE_TARGET_*Closes #22044
Test plan
test/repro/maintainer_gap_reflection_attribute_get_target.phptest/compliance/cases/stdlib/reflection/reflection_attribute_get_target.phpt(VM + JIT via phpunit filter)php script/bootstrap-inventory.php --check→ OK 6335/6335Verification transcript
Made with Cursor