Stdlib: is_uploaded_file() VM + LLVM JIT/AOT - #2206
Merged
Merged
Conversation
Closes #2204. Reuses upload temp validation from move_uploaded_file via phpc_upload_temp.c; adds StringFsDir JIT bitcode linking and fixes AOT segfault (missing stdlib.h for getenv). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_uploaded_file(string $filename): boolfor VM, JIT, and AOT using native upload temp validation (no PHP internal wrappers).lib/AOT/runtime/phpc_upload_temp.cand addsStringFsDirJIT bitcode linking (also fixesmove_uploaded_fileAOT segfault via missingstdlib.h).Closes #2204
Test plan
vendor/bin/phpunit test/unit/IsUploadedFileBuiltinTest.phpvendor/bin/phpunit test/aot/AotTest.php --filter is_uploaded_filephp bin/vm.phpwith tempnam +is_uploaded_filevendor/bin/phpunit test/aot/AotTest.php --filter move_uploaded_file(AOT green after upload runtime split)Made with Cursor