Stdlib: thin AOT session wire multi-key + int/bool/null (#21922) - #21944
Merged
Merged
Conversation
Loop LLVM session load over concatenated php-src wire pairs and emit i:/b:/N; on save so multi-string round-trips and scalar types persist. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emitSessionWireLoadFromPathover concatenated php-src session wire pairs (s:/i:/b:/N;)%.*s|i:%lld;/b:%d;/N;) in addition to stringsSessionWireMultiKeyTest+ keepSessionsWebAotExecuteTestgreenCloses #21922
php-src:
ext/session/session.c/mod_php.c— PHP impl:ext/standard/JitSessionStorageKernel.phpVerification
Note: reading int/bool session values (cast/echo) still hits a pre-existing thin-AOT HT scalar read crash; wire persist + isset + multi-string round-trip are green. Null assign into
$_SESSIONstill does not insert an HT entry under thin AOT (VM path does).Test plan
Made with Cursor