Skip to content

Fix concat into slot-less destination (#21886) + self-host bundle compile OOM + measured iteration costs #21908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurHur merged 3 commits into from
Jul 21, 2026
Merged

Fix concat into slot-less destination (#21886) + self-host bundle compile OOM + measured iteration costs #21908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
828ed5e
Foundation: apply the self-host bundle memory bump to compiles, not j…
anmichels Jul 21, 2026
ff91415
docs: record measured AOT iteration costs in the bootstrap workflow
anmichels Jul 21, 2026
742afd1
Fix concat into a slot-less destination — 'Store operand must be a po…
anmichels Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bin/compile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,13 @@ function run(string $filename, string $code, array $options): void
fwrite(STDERR, 'phpc lint: OK (bundle cache hit '.basename($bundleLintCacheFile).", #16508)\n");
exit(0);
}
// The mega-bundle compile needs ~2-4G; the 1536M default OOMs (#16508).
}

// Self-host bundles need ~2-4G whether we are LINTING or COMPILING them; the
// 1536M default OOMs deep inside php-cfg Traverser with no hint that the cap is
// the cause (#16508). The bump used to sit inside the `-l` branch above, so
// `bin/compile.php -o OUT test/selfhost/.../main.php` still died at 1536M.
if ('' !== $normalized && str_contains($normalized, 'test/selfhost/')) {
$bundleLimit = getenv('PHP_COMPILER_MEMORY_LIMIT');
if (false === $bundleLimit || '' === $bundleLimit || '1536M' === $bundleLimit || '2G' === $bundleLimit) {
ini_set('memory_limit', '6G');
Expand Down
Loading