Stdlib: mail() array additional_headers + ValueError parity (#21432) - #21436
Merged
Merged
Conversation
Port php_mail_build_headers() checks so mail() accepts array|string headers and rejects To/Subject, invalid names, and bare CR/LF/NUL like Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mail()$additional_headersacceptsarray|string(php-srcZ_PARAM_ARRAY_HT_OR_STR).php_mail_build_headers()/ field name+value validation:To/Subject→ValueError, invalid CR/LF/NUL, string-only reserved headers, numeric key rejection.php-src:
ext/standard/mail.c(php_mail_build_headers).PHP:
ext/standard/VmMail.php,ext/standard/mail.php.Closes #21432
Test plan
php bin/vm.php test/repro/issue_21432_mail_headers_array.php→OKvendor/bin/phpunit test/compliance/VMTest.php --filter 'mail_headers_array|mail_sendmail_transport|mail_registered'→ OK (5)Made with Cursor