mbstring: mb_ucwords() on PHP 8.4 forward profile (#21394) - #21407
Merged
Merged
Conversation
Register mb_ucwords as MB_CASE_TITLE over the full string so PROFILE=8.4 matches Zend function_exists and title-case behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_ucwords()inext/mbstring/mb_ucwords.php, delegating toVmMbstring::ucwords()(MB_CASE_TITLE, same path asmb_convert_case).function_exists()onCompilerVersion::supportsMbUcwords()/advertisesMbUcwords()(8.4 forward profile, aligned withmb_trim).ext/mbstring/mb_ucwords.php.Closes #21394
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_mb_ucwords_missing_forward84.php→mb_ucwords=yes/Hello WorldPHP_COMPILER_PROFILE=8.4 ./vendor/bin/phpunit test/compliance/VMTest.php --filter mb_ucwords→ OK (2 tests)./vendor/bin/phpunit test/compliance/VMTest.php --filter mb_ucwords→ phantom OK on reference profile./vendor/bin/phpunit test/unit/CompilerVersionGateTest.php --filter MbUcwords→ OKphp script/check-selfhost-spine-coverage-sync.php→ OKphp script/bootstrap-inventory.php --check→ OK 6162/6162make bootstrap-selfhost-vm-driver-execute-probe→ OKMade with Cursor