Repository navigation
Fix implicit nullable param deprecation for PROFILE=8.4 - #21397
Merged
Merged
Conversation
Emit the Zend-matching compile-time E_DEPRECATED for typed `= null` params behind a new profile gate and add compliance guards for 8.4 emit / 8.3 silence across functions, methods, closures, and arrows. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21390
Summary
CompilerVersion::supportsImplicitNullableParameterDeprecation()(8.4+ language-profile gate)E_DEPRECATEDduring parameter compilation for implicit-nullable typed params (int $x = null) using VM error pipeline soset_error_handler()observes itVerification
PHP_COMPILER_PROFILE=8.4 php bin/vm.php /tmp/issue21390_repro.php[8192] Implicitly marking parameter $x as nullable is deprecated, the explicit nullable type must be used instead./script/docker-exec.sh -- bash -lc 'php vendor/bin/phpunit test/compliance --filter implicit_nullable_parameter'OK (4 tests, 4 assertions)pytest tests/ -q1 passed in 0.01sMade with Cursor