Repository navigation
Test: lock fputcsv enum field Error parity (#5898) - #21206
Merged
Merged
Conversation
VmFputcsv already throws Zend’s Error for enum cases in fields (assign and void). Add repro + compliance PHPT so the php-src-strict contract stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmFputcsv::coerceFieldCellalready throwsError: Object of class E could not be converted to stringfor enum fields (assign + void) — matches php-srcphp_fputcsv().fputcsv_enum_field[.phpt|_jit.phpt]) to lock the contract.php-src:
ext/standard/file.cphp_fputcsv()PHP impl: existing
ext/standard/VmFputcsv.php(no new C)Closes #5898
Test plan
php bin/vm.php test/repro/issue_5898_fputcsv_enum_field.php→ Error (assign + void)php bin/jit.phpsame → Error; JIT_EXIT=0--filter fputcsv_enum_fieldOK (2)*_enum_*names (Language: backed enum string context — echo case prints backed scalar (Zend zend_enum.c parity) #3518 MCJIT DECLARE_ENUM gate); JIT covered viabin/jit.phpMade with Cursor