php-in-php: drop JitEnv putenv thin libc fork — always GetenvJitHelper (#21023) - #21042
Merged
Merged
Conversation
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isThinStandaloneAotMainlibc-only fork fromJitEnv::putenv/putenvFromCStringLiteral— thin + embed always NestedJITGetenvJitHelper::putenv+ libc setenv mirror (peer getenv php-in-php: drop isThinStandaloneAotMain libc fork from StringGetenv — always JitVmHelperLink + GetenvJitHelper (re-#20156) #20644 / rename php-in-php: drop isThinStandaloneAotMain libc fork from StringRename — always JitVmHelperLink + RenameJitHelper (re-#20028) #20603).int1soInternal::calltype inference works (putenv_smokeno longer dies onint8).JitEnv.php.C runtime: no new
runtime/*.c; net shrink is the thin LLVM early-return (~15 LOC of forked emit path).Closes #21023
Test plan
vendor/bin/phpunit test/unit/PutenvRuntimeShrinkTest.php→ OK (2 tests, 11 assertions)./phpc build -o /tmp/putenv_smoke test/bootstrap-aot/putenv_smoke.php && /tmp/putenv_smoke→putenv okmake bootstrap-selfhost-vm-driver-execute-probe→ OKVerification transcript
Made with Cursor