Skip to content

Stdlib: resourcebundle_get_error_code/message procedurals (#20853) - #20880

Merged
PurHur merged 1 commit into
masterfrom
fix/20853-resourcebundle-error-procedural
Jul 19, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/20853-resourcebundle-error-procedural

Conversation

@PurHur

@PurHur PurHur commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Register resourcebundle_get_error_code / resourcebundle_get_error_message as thin PHP procedurals over VmResourceBundle (same shape as collator_get_error_*).
  • Spine + inventory footnotes 5907/5907; gen-0 sidecar stamp updated.
  • Compliance test/compliance/cases/intl/resourcebundle_error_procedural_20853.phpt.

Closes #20853

php-src reference

  • ext/intl/resourcebundle/resourcebundle.stub.php
  • ext/intl/resourcebundle/resourcebundle_class.c

Test plan

  • Issue repro: PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_20853_resourcebundle_error_procedural.php → procedurals yes; OOP/proc match
  • PHP_COMPILER_PROFILE=8.4 vendor/bin/phpunit --filter resourcebundle_error_procedural_20853 → OK (2 tests)
  • inventory/spine/sidecar checks → OK 5907/5907

Made with Cursor

)

Thin PHP procedurals over VmResourceBundle OOP error accessors; spine/inventory
synced to 5907/5907 with gen-0 sidecar stamp — no new C.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 546d723 into master Jul 19, 2026
@PurHur
PurHur deleted the fix/20853-resourcebundle-error-procedural branch July 19, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: resourcebundle_get_error_code()/resourcebundle_get_error_message() missing — OOP OK after #20739 (ext/intl/resourcebundle)

1 participant