Repository navigation
Stdlib: IntlDatePatternGenerator create/getBestPattern (#20740) - #20819
Merged
Merged
Conversation
Add PHP 8.1+ IntlDatePatternGenerator via ICU udatpg_* FFI with a small CLDR fallback table so skeleton→pattern lookup works under PROFILE=8.4. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 19, 2026
PurHur
added a commit
that referenced
this pull request
Jul 19, 2026
…20819 (#10533) (#20831) Restore 5853/5853 spine coverage and gen-0 sidecar stamp so north-star5-fast and user_release_ready stay green after formatObject / DatePatternGenerator landed without spine requires. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmIntlDatePatternGenerator(create/__construct/getBestPattern) registered with IntlDateFormatter.udatpg_*FFI when libicui18n is present; static en_US/de_DE fallback otherwise..phpt+ issue repro. No newruntime/C.Closes #20740
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_20740_intl_date_pattern_generator.phpvendor/bin/phpunit --filter intl_date_pattern_generator→ OK (2 tests, VM+JIT, 3×)php script/bootstrap-inventory.php --check→ OK./script/check-generated-docs.sh→ in syncphp-src-strict; no php-compiler-strict shortcut.
Made with Cursor