Repository navigation
Stdlib: curl_escape/unescape(null) TypeError on PROFILE=8.4 (#20695) - #20731
Merged
Merged
Conversation
Use Z_PARAM_STR coerce/lower paths so null rejects under forward 8.4 like urlencode, with AOT early-return to avoid linking rawurlencode after abort. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl_escape/curl_unescape$stringthroughVmString::coerceZparamStrBuiltinArg+JitStringBuiltinArg::lowerZparamStrso null TypeErrors underPHP_COMPILER_PROFILE=8.4(php-src-strict; matchesurlencode).__string__rawurlencodeafter TypeError+abort.''.Closes #20695
php-src reference
curl_escape/curl_unescape(string $stringnon-nullable)PHP implementation
ext/curl/curl_escape.php,ext/curl/curl_unescape.phpVerification
Pillar 1 (pre-claim)
user_release_ready: yesTest plan
Made with Cursor